Skip to content

Remove version and default bridge network #1189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2025
Merged

Remove version and default bridge network #1189

merged 1 commit into from
May 8, 2025

Conversation

emfox
Copy link
Contributor

@emfox emfox commented Apr 1, 2025

  1. 'version' is obsolete.
  2. Connect to default bridge is not recommended, just let docker create a 'nginx-proxy_default' bridge by default, or define named network.

@emfox
1. 'version' is obsolete.
c055c40 
2. Connect to default bridge is not recommended, just let docker
   create a 'nginx-proxy_default' bridge by default, or define named
   network.
@emfox
Copy link
Contributor Author

emfox commented Apr 1, 2025

"The default bridge network is considered a legacy detail of Docker and is not recommended for production use. " from official documentation:
https://docs.docker.com/engine/network/drivers/bridge/#use-the-default-bridge-network

@buchdag buchdag added the type/docs PR with documentation only changes label May 8, 2025
@buchdag
Copy link
Member

buchdag commented May 8, 2025

Thanks @emfox 👍

@buchdag buchdag merged commit e602d9e into nginx-proxy:main May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buchdag buchdag buchdag approved these changes

Assignees
No one assigned
Labels
type/docs PR with documentation only changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emfox @buchdag